implement messageFormat transformer [WIP]#48
Draft
lunarW1TCH wants to merge 6 commits intonanostores:mainfrom
Draft
implement messageFormat transformer [WIP]#48lunarW1TCH wants to merge 6 commits intonanostores:mainfrom
lunarW1TCH wants to merge 6 commits intonanostores:mainfrom
Conversation
Member
|
Very interesting PR! I am waiting more implementation to review (types looks like working according to the tests, the modern TS is an encrypted code not for humans anyway) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript-side implementation of
messageFormattransformer based on MessageFormat 2 standard (see #39).I wanted to get some feedback before trying to implement actual transform in javascript. For now I have fully typed the transformer and created tests for the types. Hence this PR is WIP.
This implementation supports only variables and markup from MF2 standard for now. Functions and matchers are unsupported.
Is there anything I should change in types before I start implementing js code?